[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size
Alex Langford via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jun 15 13:30:48 PDT 2023
bulbazord added inline comments.
================
Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:592
if (data_sp->GetByteSize() < length)
- data_sp = MapFileData(file, -1, file_offset);
+ data_sp = MapFileData(file, length, file_offset);
if (data_sp)
----------------
A length of `-1` means "map the whole file", if my understanding is correct. Why do we want to change this to `length` instead of just -1? Or is this `file` the entire zip file?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152757/new/
https://reviews.llvm.org/D152757
More information about the lldb-commits
mailing list