[Lldb-commits] [PATCH] D153060: lldb: do more than 1 kilobyte at a time to vastly increase binary sync speed

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.

Yeah that's an unintended bottleneck.  If you're debugging to debugserver on a darwin system, it will tell lldb it uses a 128k max packet size, so larger read requests are still being broken up in to 128k chunks.  The 128k size was set when we found little perf benefit from larger packet sizes.  But using a 1k local buffer in this method to transfer binaries is unnecessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153060/new/

https://reviews.llvm.org/D153060