[Lldb-commits] [PATCH] D153054: [lldb][NFCI] TypeSystemClang::GetTypeForIdentifier should take a StringRef

[Alex Langford via Phabricator via lldb-commits]

bulbazord added inline comments.


================
Comment at: lldb/source/Plugins/Language/ObjC/NSDictionary.cpp:76
+
+  compiler_type = scratch_ts_sp->GetTypeForIdentifier<clang::CXXRecordDecl>(g_lldb_autogen_nspair);
+
----------------
aprantl wrote:
> why not directly pass in `"__lldb_autogen_nspair"` here?
It's used below as well, I didn't trust myself to be able to type it correctly twice in a row. :)
It's also nice that we can `constexpr` the llvm::StringRef and avoid computing the length at runtime, but that's a minor thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153054/new/

https://reviews.llvm.org/D153054