[Lldb-commits] [lldb] 048204d - [lldb] Remove lldbassert from DebugNamesDWARFIndex::GetGlobalVariables

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2023-06-14T17:15:20-07:00
New Revision: 048204d6102ab984c067c1a1c9889edb7f58d419

URL: https://github.com/llvm/llvm-project/commit/048204d6102ab984c067c1a1c9889edb7f58d419
DIFF: https://github.com/llvm/llvm-project/commit/048204d6102ab984c067c1a1c9889edb7f58d419.diff

LOG: [lldb] Remove lldbassert from DebugNamesDWARFIndex::GetGlobalVariables

34a8e6eee666 changed SymbolFileDWARF::GetDwoNum to
SymbolFileDWARF::GetFileIndex but changed the meaning from just DWO to
DWO and OSO which changed the meaning of the assert. The assert was
therefore removed from ManualDWARFIndex::GetGlobalVariables and
ManualDWARFIndex::GetGlobalVariables but was still present in
DebugNamesDWARFIndex::GetGlobalVariables. If we want to reintroduce the
assert, we need something with the old semantics for all 3.

Added: 
    

Modified: 
    lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp
index c72d5ccabd1dc..d09e233441de6 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp
@@ -126,7 +126,6 @@ void DebugNamesDWARFIndex::GetGlobalVariables(
 
 void DebugNamesDWARFIndex::GetGlobalVariables(
     DWARFUnit &cu, llvm::function_ref<bool(DWARFDIE die)> callback) {
-  lldbassert(!cu.GetSymbolFileDWARF().GetFileIndex());
   uint64_t cu_offset = cu.GetOffset();
   bool found_entry_for_cu = false;
   for (const DebugNames::NameIndex &ni: *m_debug_names_up) {