[Lldb-commits] [PATCH] D152917: [LLDB] Add table formatting for register fields

Jason Molenda via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 14 13:27:23 PDT 2023


jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lldb/include/lldb/Target/RegisterFlags.h:96
 
+  /// Produce a text table showing the layout of all the fields. Unamed/padding
+  /// fields will be included, with only their positions shown.
----------------
"Unnamed"


================
Comment at: lldb/source/Target/RegisterFlags.cpp:149
+    // column, just let it overflow and we'll wrap next time around. There's not
+    // mich we can do with a very small terminal.
+    if (current_width && ((current_width + column_width + 1) >= max_width)) {
----------------
"much"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152917/new/

https://reviews.llvm.org/D152917



More information about the lldb-commits mailing list