[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

Dave Lee via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 12 17:52:45 PDT 2023


kastiglione added inline comments.


================
Comment at: lldb/scripts/generate-project.py:21
+def generate_c_header(directory: str, index: int) -> None:
+    header_path = f"{directory}/obj{index}.h"
+    with open(header_path, "w") as f:
----------------
kastiglione wrote:
> os.path.join to be windows friendly?
I just noticed the contents of the makefiles also have forward slashes, so I retract my comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152569/new/

https://reviews.llvm.org/D152569



More information about the lldb-commits mailing list