[Lldb-commits] [PATCH] D152324: [lldb][NFCI] Change return type of PersistentExpressionState::GetNextPersistentVariableName

[Alex Langford via Phabricator via lldb-commits]

bulbazord added a comment.

In D152324#4415324 <https://reviews.llvm.org/D152324#4415324>, @jingham wrote:

> I wonder about this one.  In every instance where the API is used, its result is turned into a ConstString first.  That's because this variable name lives in the same slot as normal variable names, which come from the debug information and so tend to be in the ConstString pool for better reasons.  Do you project being able to get rid of that latter requirement?  If not, it seems a bit odd to go to the trouble to avoid this value starting life as a ConstString when the first thing everybody does with it is to turn it into a ConstString.

That's the major reason I'm sitting on this right now. I want to gather some more evidence and test things more before deciding this is the direction to go in. I'm pretty sure `ConstString` in its current form is the wrong abstraction for this, but perhaps some kind of variation of `ConstString` is the right call? We'll see...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152324/new/

https://reviews.llvm.org/D152324