[Lldb-commits] [lldb] aff35b2 - [lldb][NFCI] Replace some static ConstStrings with StringLiterals in Disassembler

[Alex Langford via lldb-commits]

Author: Alex Langford
Date: 2023-06-09T15:38:48-07:00
New Revision: aff35b2f1ef5de1ec5c40e5dca3b88c556e03554

URL: https://github.com/llvm/llvm-project/commit/aff35b2f1ef5de1ec5c40e5dca3b88c556e03554
DIFF: https://github.com/llvm/llvm-project/commit/aff35b2f1ef5de1ec5c40e5dca3b88c556e03554.diff

LOG: [lldb][NFCI] Replace some static ConstStrings with StringLiterals in Disassembler

These should have been replaced in e53e1de57ecc but I missed them
because ConstStrings can be implicitly converted to llvm::StringRefs.

Added: 
    

Modified: 
    lldb/source/Core/Disassembler.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Core/Disassembler.cpp b/lldb/source/Core/Disassembler.cpp
index 09eee082bc394..5e79aa40cb33e 100644
--- a/lldb/source/Core/Disassembler.cpp
+++ b/lldb/source/Core/Disassembler.cpp
@@ -893,8 +893,8 @@ bool Instruction::TestEmulation(Stream *out_stream, const char *file_name) {
 
   OptionValueDictionary *data_dictionary =
       data_dictionary_sp->GetAsDictionary();
-  static ConstString description_key("assembly_string");
-  static ConstString triple_key("triple");
+  static constexpr llvm::StringLiteral description_key("assembly_string");
+  static constexpr llvm::StringLiteral triple_key("triple");
 
   OptionValueSP value_sp = data_dictionary->GetValueForKey(description_key);