[Lldb-commits] [PATCH] D152364: [lldb] Rate limit progress reports -- different approach [WIP-ish]

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D152364#4406704 <https://reviews.llvm.org/D152364#4406704>, @saugustine wrote:

> What other progress reporting needs rate limiting?
>
> To the best of my knowledge, we have only identified one location--this one. So I'm not sure a fully general solution is in order here under the YAGNI principle.
>
> I favor rate limiting close to the source because generating events and throwing them away is pure waste and gives an overall sense to the user that lldb is slow.

While generality is part of why I favor doing the rate limiting in the listener, it also means that the listener can decide the rate. For example, VSCode could decide they don't need rate limiting (as is the case today) while the default event handler in LLDB could make a different decision (for example based on whether you're in a fast TTY).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152364/new/

https://reviews.llvm.org/D152364