[Lldb-commits] [PATCH] D152324: [lldb][NFCI] Change return type of PersistentExpressionState::GetNextPersistentVariableName

Wed Jun 7 17:22:59 PDT 2023

bulbazord added a comment.

In D152324#4403368 <https://reviews.llvm.org/D152324#4403368>, @aprantl wrote:

> Is the idea to remove the ConstString from these APIs too? If yes, this LGTM, otherwise it seems to needlessly complicate things.

Yes, I was going to remove ConstString from these other APIs too. I can let this patch sit here until I can do more work to make sure that happens though. I'm somewhat confident that removing ConstString from this area of LLDB is going to be better long-term, but I've been wrong about this before! :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152324/new/

https://reviews.llvm.org/D152324