[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set a label to targets

[Haowei Wu via Phabricator via lldb-commits]

haowei added a comment.

Hi

The `lldb-shell :: Target/target-label.test` is broken on our LLVM builder after this change was landed. Error message we saw:

  Script:
  --
  : 'RUN: at line 1';   /b/s/w/ir/x/w/staging/llvm_build/bin/lldb --no-lldbinit -S /b/s/w/ir/x/w/staging/llvm_build/tools/lldb/test/Shell/lit-lldb-init-quiet -b -o 'settings set interpreter.stop-command-source-on-error false' -s /b/s/w/ir/x/w/llvm-llvm-project/lldb/test/Shell/Target/target-label.test 2>&1 | /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck /b/s/w/ir/x/w/llvm-llvm-project/lldb/test/Shell/Target/target-label.test
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /b/s/w/ir/x/w/llvm-llvm-project/lldb/test/Shell/Target/target-label.test:9:10: error: CHECK: expected string not found in input
  # CHECK: * target #0: /bin/ls
           ^
  <stdin>:10:26: note: scanning from here
  * target #0 (ls): /bin/ls ( arch=x86_64-*-linux, platform=host )
                           ^
  <stdin>:29:2: note: possible intended match here
   target #2: /bin/cat ( arch=x86_64-*-linux, platform=host )
   ^
  
  Input file: <stdin>
  Check file: /b/s/w/ir/x/w/llvm-llvm-project/lldb/test/Shell/Target/target-label.test
  
  -dump-input=help explains the following input dump.
  
  Input was:
  <<<<<<
             .
             .
             .
             5: (lldb) command source -s 0 '/b/s/w/ir/x/w/llvm-llvm-project/lldb/test/Shell/Target/target-label.test' 
             6: Executing commands in '/b/s/w/ir/x/w/llvm-llvm-project/lldb/test/Shell/Target/target-label.test'. 
             7: (lldb) target create -l "ls" /bin/ls 
             8: (lldb) target list 
             9: Current targets: 
            10: * target #0 (ls): /bin/ls ( arch=x86_64-*-linux, platform=host ) 
  check:9'0                              X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
            11: (lldb) script lldb.target.SetLabel("") 
  check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            12: error: there is no embedded script interpreter in this mode. 
  check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            13: (lldb) target list 
  check:9'0     ~~~~~~~~~~~~~~~~~~~
            14: Current targets: 
  check:9'0     ~~~~~~~~~~~~~~~~~
            15: * target #0 (ls): /bin/ls ( arch=x86_64-*-linux, platform=host ) 
  check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             .
             .
             .
            24: error: Cannot use integer as target label. 
  check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            25: (lldb) target select 0 
  check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~
            26: Current targets: 
  check:9'0     ~~~~~~~~~~~~~~~~~
            27: * target #0 (ls): /bin/ls ( arch=x86_64-*-linux, platform=host ) 
  check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            28:  target #1 (cat): /bin/cat ( arch=x86_64-*-linux, platform=host ) 
  check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            29:  target #2: /bin/cat ( arch=x86_64-*-linux, platform=host ) 
  check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  check:9'1      ?                                                           possible intended match
            30:  target #3: /bin/cat ( arch=x86_64-*-linux, platform=host ) 
  check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            31: (lldb) target select cat 
  check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~
            32: Current targets: 
  check:9'0     ~~~~~~~~~~~~~~~~~
            33:  target #0 (ls): /bin/ls ( arch=x86_64-*-linux, platform=host ) 
  check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            34: * target #1 (cat): /bin/cat ( arch=x86_64-*-linux, platform=host ) 
  check:9'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             .
             .
             .
  >>>>>>
  
  --

Link to the builder: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8779016248689544129/overview

Could you take a look? If it takes some time to fix, could you revert this change please?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151859/new/

https://reviews.llvm.org/D151859