[Lldb-commits] [lldb] 431f082 - [lldb] Disable some tests on windows

Med Ismail Bennani via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 6 16:10:25 PDT 2023


Author: Med Ismail Bennani
Date: 2023-06-06T16:10:05-07:00
New Revision: 431f082a55488b12ae12d4330b6c6c61dc3e61be

URL: https://github.com/llvm/llvm-project/commit/431f082a55488b12ae12d4330b6c6c61dc3e61be
DIFF: https://github.com/llvm/llvm-project/commit/431f082a55488b12ae12d4330b6c6c61dc3e61be.diff

LOG: [lldb] Disable some tests on windows

This patch skips both `test_completion_target_create_from_root_dir`
introduced in `e896612` and  `target-label.test` introduced in `1e82b20`
since I don't have a windows machine to try to accomodate the filesystem
path style differences for these tests to pass.

Signed-off-by: Med Ismail Bennani <ismail at bennani.ma>

Added: 
    

Modified: 
    lldb/test/API/functionalities/completion/TestCompletion.py
    lldb/test/Shell/Target/target-label.test

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/completion/TestCompletion.py b/lldb/test/API/functionalities/completion/TestCompletion.py
index 0cfd213177d6a..bc39f18fb225b 100644
--- a/lldb/test/API/functionalities/completion/TestCompletion.py
+++ b/lldb/test/API/functionalities/completion/TestCompletion.py
@@ -477,6 +477,7 @@ def test_custom_command_completion(self):
         self.complete_from_to("my_test_cmd main.cp", ["main.cpp"])
         self.expect("my_test_cmd main.cpp", substrs=["main.cpp"])
 
+    @skipIfWindows
     def test_completion_target_create_from_root_dir(self):
         """Tests source file completion by completing ."""
         root_dir = os.path.abspath(os.sep)

diff  --git a/lldb/test/Shell/Target/target-label.test b/lldb/test/Shell/Target/target-label.test
index 7194f4b558f34..e550e863dbe1b 100644
--- a/lldb/test/Shell/Target/target-label.test
+++ b/lldb/test/Shell/Target/target-label.test
@@ -1,3 +1,4 @@
+# UNSUPPORTED: system-windows
 # RUN: %lldb -b -o 'settings set interpreter.stop-command-source-on-error false' -s %s 2>&1 | FileCheck %s
 
 target create -l "ls" /bin/ls


        


More information about the lldb-commits mailing list