[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere requested changes to this revision.
JDevlieghere added inline comments.
This revision now requires changes to proceed.


================
Comment at: lldb/include/lldb/Utility/Broadcaster.h:157
+  ///   A StringRef of the name that this broadcaster will have.
+  Broadcaster(lldb::BroadcasterManagerSP manager_sp, llvm::StringRef name);
 
----------------
If we're going to store this as a `std::string` you should take it it by value and move it into the member. 


================
Comment at: lldb/source/Utility/Broadcaster.cpp:26-28
+Broadcaster::Broadcaster(BroadcasterManagerSP manager_sp, llvm::StringRef name)
     : m_broadcaster_sp(std::make_shared<BroadcasterImpl>(*this)),
+      m_manager_sp(std::move(manager_sp)), m_broadcaster_name(name.str()) {
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152220/new/

https://reviews.llvm.org/D152220