[Lldb-commits] [PATCH] D152012: [lldb/crashlog] Expand crash report file path before parsing
Med Ismail Bennani via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Jun 2 11:25:18 PDT 2023
mib added a comment.
In D152012#4391336 <https://reviews.llvm.org/D152012#4391336>, @bulbazord wrote:
> The key here is that you're expanding the path and checking for the validity before calling `CrashLogParser.create()` right? It looks like for the `load_crashlog_in_scripted_process` case nothing has changed. If my understanding is correct, then this looks good to me.
Yep, I had to fixed this in the past for interactive mode in a07a751 <https://reviews.llvm.org/rGa07a75180c01a3f262b02f69ee5722080da74b84> but not for the regular crashlog command. This patch refactors it to cover both cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152012/new/
https://reviews.llvm.org/D152012
More information about the lldb-commits
mailing list