[Lldb-commits] [PATCH] D151919: [lldb][NFCI] Apply IndexEntry to DWARFUnitHeader outside of extraction

[Alex Langford via Phabricator via lldb-commits]

bulbazord added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:889
+        "Package unit with a non-zero abbreviation offset");
+
+  auto *unit_contrib = index_entry->getContribution();
----------------
aprantl wrote:
> I know this was also in the original code, so you may not know either: Should these error messages be limited to dwarf packages (.dwp) or should they be more generic?
I'm not sure, but my understanding is that we only apply the index entry to the header in DWO contexts, so I assume DWP is involved.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:980
+      entry = index.getFromOffset(expected_header->GetOffset());
+    if (entry) {
+      if (llvm::Error err = expected_header->ApplyIndexEntry(entry)) {
----------------
aprantl wrote:
> llvm coding style would delete most of these {} ?
Sounds good, I'll update.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151919/new/

https://reviews.llvm.org/D151919