[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set a label to targets
Med Ismail Bennani via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jun 1 13:03:35 PDT 2023
mib updated this revision to Diff 527580.
mib marked an inline comment as done.
mib retitled this revision from "[lldb/Target] Add ability to set name to targets" to "[lldb/Target] Add ability to set a label to targets".
mib edited the summary of this revision.
mib added a comment.
Address @bulbazord & @jingham's comments:
- Rename name -> label
- Add test
- Add sanity check to avoid having integer only labels
- Add target index when label already exist for another target
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151859/new/
https://reviews.llvm.org/D151859
Files:
lldb/include/lldb/API/SBTarget.h
lldb/include/lldb/Target/Target.h
lldb/include/lldb/Target/TargetList.h
lldb/source/API/SBTarget.cpp
lldb/source/Commands/CommandObjectTarget.cpp
lldb/source/Target/Target.cpp
lldb/source/Target/TargetList.cpp
lldb/test/Shell/Target/target-label.test
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151859.527580.patch
Type: text/x-patch
Size: 11119 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230601/aa9d4e87/attachment-0001.bin>
More information about the lldb-commits
mailing list