[Lldb-commits] [PATCH] D151849: [lldb/crashlog] Create interactive crashlog with no binary

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 1 12:51:30 PDT 2023


mib updated this revision to Diff 527575.
mib marked an inline comment as done.
mib added a subscriber: jingham.
mib added a comment.

Address @bulbazord & @jingham's comments:

- Rename name -> label
- Add test
- Add sanity check to avoid having integer only labels
- Add target index when label already exist for another target


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151849/new/

https://reviews.llvm.org/D151849

Files:
  lldb/include/lldb/API/SBTarget.h
  lldb/include/lldb/Target/Target.h
  lldb/include/lldb/Target/TargetList.h
  lldb/source/API/SBTarget.cpp
  lldb/source/Commands/CommandObjectTarget.cpp
  lldb/source/Target/Target.cpp
  lldb/source/Target/TargetList.cpp
  lldb/test/Shell/Target/target-label.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151849.527575.patch
Type: text/x-patch
Size: 11075 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230601/36e61c00/attachment-0001.bin>


More information about the lldb-commits mailing list