[Lldb-commits] [PATCH] D151844: [lldb/crashlog] Fix crash when loading non-symbolicated report

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 31 15:50:22 PDT 2023


mib added inline comments.


================
Comment at: lldb/examples/python/crashlog.py:599-602
+            if 'symbol' in json_frame:
+                symbol = json_frame['symbol']
+                location = 0
+                if "symbolLocation" in json_frame and json_frame["symbolLocation"]:
----------------
bulbazord wrote:
> nit: Why use single quotes for `'symbol'` but double quotes for `"symbolLocation"`? Did some python formatter gives you this?
yep


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151844/new/

https://reviews.llvm.org/D151844



More information about the lldb-commits mailing list