[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 31 08:47:14 PDT 2023


JDevlieghere accepted this revision.
JDevlieghere added inline comments.


================
Comment at: lldb/source/Core/ValueObject.cpp:434
   ValueObjectSP root(GetSP());
-  for (ConstString name : names) {
+  for (auto name : names) {
     root = root->GetChildMemberWithName(name, true);
----------------
I don’t think this qualifies for ‘auto’ according to the LLVM coding guidelines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151813/new/

https://reviews.llvm.org/D151813



More information about the lldb-commits mailing list