[Lldb-commits] [PATCH] D151762: [lldb] Remove __FUNCTION__ from log messages in lldbHost (NFC)

[Alex Langford via Phabricator via lldb-commits]

bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.

The change itself looks fine and is fairly mechanical. Easy to verify.

One thing that I see here is we're treating the result of `llvm::StringRef::data()` as a c-string which isn't guaranteed to be true. That makes me a little nervous. As frustrating as temporary allocations are, the right thing to do would be something like `foo.str().c_str()` where `foo` is a StringRef. If you think it's appropriate, can you change those instances in this patch? If not we can do it in a follow-up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151762/new/

https://reviews.llvm.org/D151762