[Lldb-commits] [lldb] f2a8661 - [LLDB] Fix TestVarPath.py for AArch64 Windows
Muhammad Omair Javaid via lldb-commits
lldb-commits at lists.llvm.org
Mon May 29 05:32:05 PDT 2023
Author: Muhammad Omair Javaid
Date: 2023-05-29T16:17:13+04:00
New Revision: f2a866170c4961137608eee1c26f6eaa1e8e62a1
URL: https://github.com/llvm/llvm-project/commit/f2a866170c4961137608eee1c26f6eaa1e8e62a1
DIFF: https://github.com/llvm/llvm-project/commit/f2a866170c4961137608eee1c26f6eaa1e8e62a1.diff
LOG: [LLDB] Fix TestVarPath.py for AArch64 Windows
Since 44bb442 LLDB TestVarPath.py crashes on AArch64 Windows.
GetValueForVariablePath function seems to be triggering the crash.
This patch disable parts of this test causing the crash.
Bug reported upstream:
https://github.com/llvm/llvm-project/issues/62983
Added:
Modified:
lldb/test/API/functionalities/var_path/TestVarPath.py
Removed:
################################################################################
diff --git a/lldb/test/API/functionalities/var_path/TestVarPath.py b/lldb/test/API/functionalities/var_path/TestVarPath.py
index 06b4a2d8da313..f79b2a7584ae9 100644
--- a/lldb/test/API/functionalities/var_path/TestVarPath.py
+++ b/lldb/test/API/functionalities/var_path/TestVarPath.py
@@ -5,6 +5,7 @@
import lldb
import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.decorators import *
from lldbsuite.test.lldbtest import *
@@ -115,7 +116,7 @@ def do_test(self):
self.assertSuccess(v.GetError(), "Make sure we find 'pt_sp'")
# Make sure we don't crash when looking for non existant child
# in type with synthetic children. This used to cause a crash.
- v = frame.GetValueForVariablePath("pt_sp->not_valid_child")
- self.assertTrue(
- v.GetError().Fail(), "Make sure we don't find 'pt_sp->not_valid_child'"
- )
+ if not self.isAArch64Windows():
+ v = frame.GetValueForVariablePath("pt_sp->not_valid_child")
+ self.assertTrue(v.GetError().Fail(),
+ "Make sure we don't find 'pt_sp->not_valid_child'")
More information about the lldb-commits
mailing list