[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

[Dave Lee via Phabricator via lldb-commits]

kastiglione added inline comments.


================
Comment at: lldb/examples/python/crashlog.py:703
+            symbol   = (
+                        r'(?: +(?:'  # spaces and + sign
+                        r'(.+)'      # symbol name
----------------
this is just "spaces", not "spaces and + sign"


================
Comment at: lldb/examples/python/crashlog.py:705
+                        r'(.+)'      # symbol name
+                        r'(?: \+ '   # spaces and + sign
+                        r'(\d+)'     # symbol offset
----------------
this is "space and + sign" not "spaces"


================
Comment at: lldb/examples/python/crashlog.py:710
+                        r'([^\:]+)'  # file name
+                        r'\:(\d+)'   # line number
+                        r'(?:\:'     # capture group garbage
----------------
`:` does not need to be escaped


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146765/new/

https://reviews.llvm.org/D146765