[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

[Sterling Augustine via Phabricator via lldb-commits]

saugustine updated this revision to Diff 523951.
saugustine added a comment.

Moved the rate-limiting to Debugger.[cpp|h]

Also wrote a custom getCurrentTime function, which doesn't do the
much of the extra work the Timer.h version does.

With this change, the timing is much better:

On my local machine, for a 93k DIE application, I get the following
timings:

      

1 second rate limit
(lldb) log timers dump
580.971832328 sec (total: 580.972s; child: 0.000s; count: 93007) for void DWARFUnit::ExtractDIEsRWLocked()

      

0 second rate limit, but with this change in place
663.114765369 sec (total: 663.115s; child: 0.000s; count: 93007) for void DWARFUnit::ExtractDIEsRWLocked()

      

Without this change in place
651.826884735 sec (total: 651.827s; child: 0.000s; count: 93007) for void DWARFUnit::ExtractDIEsRWLocked()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150805/new/

https://reviews.llvm.org/D150805

Files:
  lldb/include/lldb/Core/Debugger.h
  lldb/source/Core/CoreProperties.td
  lldb/source/Core/Debugger.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150805.523951.patch
Type: text/x-patch
Size: 3680 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230519/d288d4ae/attachment.bin>