[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

Thu May 18 15:35:56 PDT 2023

bulbazord marked an inline comment as done.
bulbazord added inline comments.

================
Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155
+  llvm::StringRef selector_name = GetSelector();
+  std::string name_sans_category;
+
----------------
bulbazord wrote:
> aprantl wrote:
> > bulbazord wrote:
> > > aprantl wrote:
> > > > Using an llvm string stream to construct the string might be faster here.
> > > I tested this and found that `llvm::SmallString<128>` performs about as well as `std::string` on average. `llvm::SmallString<64>` was on average slower though.
> > > 
> > > I think I'm going to land this with std::string, we can revisit later if the difference actually is measurable.
> > Maybe we were talking past each other: I was thinking about https://www.llvm.org/doxygen/classllvm_1_1raw__string__ostream.html
> Oh, I totally misread what you said. I'll try that out and create a new PR if I can improve this.
Turns out it can be improved, but it wasn't with raw_string_ostream! https://reviews.llvm.org/D150914

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149914/new/

https://reviews.llvm.org/D149914