[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

[Alex Langford via Phabricator via lldb-commits]

bulbazord added a comment.

Where do you plan on using this? Downstream I assume?



================
Comment at: lldb/source/Core/Value.cpp:134-135
+      return Value::ValueType::Invalid;
+  }
+}
+
----------------
This switch is exhaustive, could you add an `llvm_unreachable` somewhere to indicate this? After the switch or something. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150826/new/

https://reviews.llvm.org/D150826