[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

[Sterling Augustine via Phabricator via lldb-commits]

saugustine added a comment.

This update switches to a time-based approach as suggested by Jordan. However, the timing is about the same as the original. I believe because calling getCurrentTime every iteration is comparably slow as printing the progress report itself.

It probably is still a win over very slow connections, where printing is even slower and time would remain the same.

What would be ideal is a timing thread that wakes up every X seconds and prints the results, but there isn't a good mechanism for that, and doing that portably is way out of scope for this.

Shall we just switch to a percentage? Printing it every percent update?

That has the issues Jordan described, where things appear to progress quickly, and then may grind to a halt due to some big DIE.

But I think the perfect shouldn't be the enemy of the good here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150805/new/

https://reviews.llvm.org/D150805