[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 17 12:50:42 PDT 2023


JDevlieghere added a comment.

Given that here we know the `total_progress` in advance and assuming the operation is relatively evenly distributed, would it make sense to report for every percentage? We could do this in `ManualDWARFIndex::Index` or we could add something like a "Policy" or "Granularity" to the progress class (similar to what `report_increment` is doing in this class). This seems preferable compared to the rather arbitrary value of report every `1000`.

I also like Jordan's rate limiting idea. In my mind that should be a property of the broadcaster. Different tools (e.g. vscode vs the command line) could specify different values when register a listener.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150805/new/

https://reviews.llvm.org/D150805



More information about the lldb-commits mailing list