[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Wed May 17 07:40:59 PDT 2023

hans added a comment.

In D144509#4349399 <https://reviews.llvm.org/D144509#4349399>, @mstorsjo wrote:

> In D144509#4349051 <https://reviews.llvm.org/D144509#4349051>, @hans wrote:
>
>> In D144509#4347562 <https://reviews.llvm.org/D144509#4347562>, @glandium wrote:
>>
>>> FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c <https://reviews.llvm.org/rG65429b9af6a2c99d340ab2dcddd41dab201f399c> is causing problems on Windows compiler-rt for some reason I haven't identified yet (with cmake 3.25.1). Which suggests for a same version of cmake, this is actually altering its behavior, which I wouldn't have expected...
>>
>> It is indeed unfortunate that this seems to come with such a fundamental behavior change. (we already have https://github.com/llvm/llvm-project/issues/62719) Do you have a repro for the issue you're seeing?
>>
>> Since the breakages are piling up, perhaps it's time to revert this.
>
> Unfortunately, much of this is hard to sort out without actually trying to patch forward on main, since many of these issues don't show up easily in e.g. premerge testing or similar (the patch has been tried many times for months before in that form), so I'd appreciate if we'd give it a little more time to actually try to sort out the issues...

But now we have identified issues and there are reproducers available (e.g. on https://github.com/llvm/llvm-project/issues/62719). Keeping it in main is just disruptive and risks making reverting harder (it's already not a clean revert). I think the policy of reverting back to green still applies.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144509/new/

https://reviews.llvm.org/D144509