[Lldb-commits] [PATCH] D150624: [lldb] Fix lua build after 27b6a4e63afe
Alex Langford via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon May 15 17:09:10 PDT 2023
bulbazord requested review of this revision.
bulbazord added a comment.
So, I agree that we should definitely unify this or else we end up doing this for **every** scripting language that we add support for. That being said, I think this is actually better than what we had before because now we're not exposing lldb private details in the public interface. There is a TODO comment in `SWIGPythonBridge.h` already for cleaning this up when we have a moment... I don't want to block this patch unless we're ok reverting the previous one, and I'd preferably not revert that one...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150624/new/
https://reviews.llvm.org/D150624
More information about the lldb-commits
mailing list