[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere requested changes to this revision.
JDevlieghere added a comment.
This revision now requires changes to proceed.

You can do this simpler with a single `std::once_flag`.



================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp:710-715
+  std::lock_guard<std::mutex> guard(m_kext_scan_mutex);
+  if (!m_did_kext_scan) {
+    CollectKextAndKernelDirectories();
+    SearchForKextsAndKernelsRecursively();
+    m_did_kext_scan = true;
+  }
----------------



================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.h:199-200
 
+  std::mutex m_kext_scan_mutex;
+  bool m_did_kext_scan;
+
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150621/new/

https://reviews.llvm.org/D150621