[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon May 15 16:05:36 PDT 2023


bulbazord added a comment.

In D149914#4335858 <https://reviews.llvm.org/D149914#4335858>, @aprantl wrote:

> I'm not opposed to using this implementation, but have you considered using something like the stdlib regex library to do the heavy lifting?

I talked to Jonas and did a little research. It seems like `<regex>` is quite slow and many supported compilers have buggy implementations. If I were to use regular expressions to rewrite this, I'd likely use whatever LLVM has implemented. That being said, I'm not too keen on holding up this patch because of that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149914/new/

https://reviews.llvm.org/D149914



More information about the lldb-commits mailing list