[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

[Andrey Ali Khan Bolshakov via Phabricator via lldb-commits]

bolshakov-a added inline comments.


================
Comment at: clang/lib/AST/ItaniumMangle.cpp:4579
+      if (CE->hasAPValueResult())
+        mangleValueInTemplateArg(ParamType, CE->getResultAsAPValue(), false,
+                                 /*NeedExactType=*/true);
----------------
efriedma wrote:
> I'm not sure what the point of the `if (CE->hasAPValueResult())` is; are you just trying to avoid copying the APValue?  (If this is going to be a repeating pattern, maybe we can add some sort of utility class to represent the pattern.)
I don't know too, it is Richard's code. Looks really like an optimization.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140996/new/

https://reviews.llvm.org/D140996