[Lldb-commits] [PATCH] D150402: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes

[Alex Langford via Phabricator via lldb-commits]

bulbazord added a comment.

In D150402#4337400 <https://reviews.llvm.org/D150402#4337400>, @fdeazeve wrote:

> Thanks for doing this! In particular, all the early returns are very welcome :)
>
> I suspect you already have this in your radar, but `ExtractFormValueAtIndex` could probably return an `optional<DWARFFormValue>` to cleanup some code.

Yup, on the radar! :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150402/new/

https://reviews.llvm.org/D150402