[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

Dave Lee via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 11 13:20:00 PDT 2023


kastiglione added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h:61
   uint8_t m_has_children = 0;
-  DWARFAttribute::collection m_attributes;
 };
----------------
With this change, can the following be removed from` DWARFAttribute.h`?

```
typedef std::vector<DWARFAttribute> collection;
typedef collection::iterator iterator;
typedef collection::const_iterator const_iterator;
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149214/new/

https://reviews.llvm.org/D149214



More information about the lldb-commits mailing list