[Lldb-commits] [PATCH] D150228: [lldb][NFCI] Replace dw_form_t with llvm::dwarf::Form
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue May 9 15:03:29 PDT 2023
jingham added a comment.
Apparently a similar change was made with dw_tag_t, in the line below your first deletion I see:
typedef llvm::dwarf::Tag dw_tag_t;
It seems weird to have dw_tag_t but lvm::dwarf::Form. If there's a good reason to use the more verbose form, we should probably do the same with the Tag for consistency. Otherwise, you can just play the same re-typedef-ing as was done for tag, right?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150228/new/
https://reviews.llvm.org/D150228
More information about the lldb-commits
mailing list