[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

Thanks for the feedback.  Testing now & will update the patch in a bit.



================
Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:930-931
+    if (!image_infos[i].is_valid_mach_header) {
+      image_infos_array_sp->AddItem(image_info_dict_sp);
+      continue;
+    }
----------------
bulbazord wrote:
> Why do we still want to add information about this dylib if the mach header isn't valid? 
Yeah, I was being too clever here, it's not clear what I'm doing (and it's the cause of the test failure I was looking at).  I tried to overload "could not read the header/load commands" for both "it failed" and "lldb told us to not read them".  I'll pass down the bool for whether we're including the header/loadcmds to make it a lot clearer.


================
Comment at: lldb/tools/debugserver/source/RNBRemote.cpp:5932-5933
 //
 //  jGetLoadedDynamicLibrariesInfos:{"fetch_all_solibs":true}
-//      Use the new style (macOS 10.12, tvOS 10, iOS 10, watchOS 3) dyld SPI to
-//      get a list of all the
-//      libraries loaded
+//      Use the new dyld SPI to get a list of all the libraries loaded
 //
----------------
bulbazord wrote:
> Should probably update this comment with `"report_load_commands":false` as well.
Good catch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150158/new/

https://reviews.llvm.org/D150158