[Lldb-commits] [PATCH] D150160: [lldb] Simplify Log::PutString (NFC)

[Alex Langford via Phabricator via lldb-commits]

bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lldb/source/Utility/Log.cpp:135
-void Log::PutCString(const char *cstr) { Printf("%s", cstr); }
-void Log::PutString(llvm::StringRef str) { PutCString(str.str().c_str()); }
 
----------------
Amazing


================
Comment at: lldb/source/Utility/Log.cpp:151-154
 
 // All logging eventually boils down to this function call. If we have a
 // callback registered, then we call the logging callback. If we have a valid
 // file handle, we also log to the file.
----------------
We can probably update this comment as it's no longer true: `Log::PutCString` will skip `Printf` -> `VAPrintf` entirely now...



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150160/new/

https://reviews.llvm.org/D150160