[Lldb-commits] [PATCH] D149792: Add AArch64 MASK watchpoint support to debugserver

[Dan Liew via Phabricator via lldb-commits]

delcypher added inline comments.


================
Comment at: lldb/test/API/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py:132
             value.GetType().GetPointeeType())
-        # Watch for write to *g_char_ptr.
-        error = lldb.SBError()
----------------
@jasonmolenda Maybe this code should be guarded rather than deleted?

Your change looks like it only affects arm64 Apple platforms? For everything else, presumably this restriction still applies? If so maybe we should still be testing it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149792/new/

https://reviews.llvm.org/D149792