[Lldb-commits] [PATCH] D149774: [lldb] Use templates to simplify {Get, Set}PropertyAtIndex (NFC)

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 3 11:01:25 PDT 2023


bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.

I quite like the idea. Probably want to wait for others to look over it but I think it's good!



================
Comment at: lldb/source/Core/Debugger.cpp:394
   const uint32_t idx = ePropertyUseColor;
-  bool ret = m_collection_sp->SetPropertyAtIndexAsBoolean(idx, b);
+  // bool ret = m_collection_sp->SetPropertyAtIndexAsBoolean(idx, b);
+  bool ret = SetPropertyAtIndex(idx, b);
----------------
remove commented out line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149774/new/

https://reviews.llvm.org/D149774



More information about the lldb-commits mailing list