[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

In D149692#4313715 <https://reviews.llvm.org/D149692#4313715>, @mib wrote:

> This looks good to me, although I'm wondering whether instead of passing a string, we should pass a dictionary. This way the user could either fill the dictionary with a simple stop reason description or the MachException data What do you think Jim ?

ThreadPlan stop reasons are only for display purposes, we don't ever reason based on them.  We do put data in StopInfo's but this isn't constructing a StopInfo, it's just adding the string to StopInfoPlanComplete.  So I can't see what use would be made of the more complex return.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149692/new/

https://reviews.llvm.org/D149692