[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon May 1 14:05:12 PDT 2023


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lldb/source/Core/Disassembler.cpp:805
 
-      ConstString const_key(key.c_str());
+      llvm::StringRef key_ref(key);
       // Check value to see if it's the start of an array or dictionary.
----------------
I don't think you need this: `key` is a `std::string` that can be used directly. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149482/new/

https://reviews.llvm.org/D149482



More information about the lldb-commits mailing list