[Lldb-commits] [PATCH] D148395: [lldb] Unify default/hijack listener between Process{Attach, Launch}Info (NFC)

[Alex Langford via Phabricator via lldb-commits]

bulbazord added inline comments.


================
Comment at: lldb/include/lldb/Target/Process.h:122
         m_async(false) {
     ProcessInfo::operator=(launch_info);
     SetProcessPluginName(launch_info.GetProcessPluginName());
----------------
mib wrote:
> Because we moved `m_listener_sp` and `m_hijack_listener_sp` to `ProcessInfo` and since both `Process{Attach,Launch}Info` are derived from that class, this should also copy the listeners.
I don't think that's true? We're taking a different subclass and initializing from that, we have to be explicit about which fields are copied over, no? Maybe I'm missing something here.

Either way, I'm not sure it really matters unless the `ProcessLaunchInfo` and `ProcessAttachInfo` necessarily need to be in sync. Do they?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148395/new/

https://reviews.llvm.org/D148395