[Lldb-commits] [PATCH] D148380: [lldb] Lock accesses to PathMappingLists's internals

Fri Apr 21 15:27:12 PDT 2023

bulbazord added inline comments.

================
Comment at: lldb/source/Target/PathMappingList.cpp:72
 void PathMappingList::Append(const PathMappingList &rhs, bool notify) {
+  std::scoped_lock locks(m_mutex, rhs.m_mutex);
   ++m_mod_id;
----------------
nickdesaulniers wrote:
> ```
> /android0/llvm-project/lldb/source/Target/PathMappingList.cpp:72:3: warning: 'scoped_lock' may not intend to support class template argument deduction [-Wctad-maybe-unsupported]
>   std::scoped_lock locks(m_mutex, rhs.m_mutex);
>   ^
> /usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/mutex:692:11: note: add a deduction guide to suppress this warning
>     class scoped_lock
>           ^
> ```
Fixed in `c5fc7809e05940674424aaed7dd06c6be0639864`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148380/new/

https://reviews.llvm.org/D148380