[Lldb-commits] [PATCH] D148548: [lldb] Improve breakpoint management for interactive scripted process

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

LGTM but I'll hold off on accepting to give Alex a change to take another look as he had more significant comments.



================
Comment at: lldb/source/Interpreter/ScriptInterpreter.cpp:78-91
 lldb::DataExtractorSP
 ScriptInterpreter::GetDataExtractorFromSBData(const lldb::SBData &data) const {
   return data.m_opaque_sp;
 }
 
+lldb::BreakpointSP ScriptInterpreter::GetOpaqueTypeFromSBBreakpoint(
+    const lldb::SBBreakpoint &breakpoint) const {
----------------
NTBF for this patch but we should really be using templates here to avoid code duplication. 


================
Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp:124
+  if (!CheckStructuredDataObject(LLVM_PRETTY_FUNCTION, obj, error))
+    return {};
+
----------------
return false


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148548/new/

https://reviews.llvm.org/D148548