[Lldb-commits] [PATCH] D148395: [lldb] Unify default/hijack listener between Process{Attach, Launch}Info (NFC)

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added a comment.

In D148395#4270508 <https://reviews.llvm.org/D148395#4270508>, @bulbazord wrote:

> Creating a ProcessAttachInfo from a ProcessLaunchInfo with this change means they'll have different listeners. Is that ProcessLaunchInfo kept around for any other reason? Or is it just made to create the ProcessAttachInfo? This seems like a reasonable move to me, but I'm not sure how LaunchInfo and AttachInfo might interact.

Not sure what you mean ... We need to convert to the `ProcessLaunchInfo` into a `ProcessAttachInfo` when the user ask use to launch a process but we end up asking the platform to do the launch after which we attach to the process. In both cases, we use the default listener (the debugger listener if the user didn't provide a custom listener).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148395/new/

https://reviews.llvm.org/D148395