[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in passthrough mode to event listeners

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 17 14:55:20 PDT 2023


JDevlieghere added a comment.

I find "passthrough" somewhat confusing in this context. When using a listener in this new mode, where does the event go after it has pass trough this event listener? Maybe my understanding of how the event listeners is incomplete, but I was under the impression that normally there's a single listener for a certain kind of event. IIUC, in this new mode, you can have multiple listeners, where you can set one (or as Alex pointed out, possibly more) listeners that can observe events but not necessary deal with them. If that's an accurate description of the interactions, then it seems like there's more of a one-to-many relationship between events and listeners rather than what passthrough implies. I think a better name would be something like "passive listener" or "non-handling" listener or something.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148397/new/

https://reviews.llvm.org/D148397



More information about the lldb-commits mailing list