[Lldb-commits] [PATCH] D147300: [lldb] Fix build on older FreeBSD

Fri Mar 31 06:59:09 PDT 2023

emaste accepted this revision.
emaste added a comment.

In D147300#4236033 <https://reviews.llvm.org/D147300#4236033>, @dim wrote:

> LGTM, but if such SIGFPE's occur before the FPE_FLTIDO define was introduced, can they ever have value 9?

This is essentially a compile-time assertion to make sure we have the correct value for `FPE_FLTIDO`. If we're building on an older FreeBSD which does not have it defined then we can't check it anyway.

We could run an LLDB built on older FreeBSD on a newer kernel and receive `FPE_FLTIDO` I imagine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147300/new/

https://reviews.llvm.org/D147300