[Lldb-commits] [PATCH] D146977: [lldb-server/linux] Use waitpid(-1) to collect inferior events

[Felipe de Azevedo Piovezan via Phabricator via lldb-commits]

fdeazeve added a comment.

@labath I believe this broke the lldb bots, because the declaration of some virtual functions had the const qualifier removed, but not the definition:

  /Users/buildslave/jenkins/workspace/lldb-cmake at 2/llvm-project/lldb/tools/lldb-server/lldb-gdbserver.cpp:79:36: error: non-virtual member function marked 'override' hides virtual member function
           MainLoop &mainloop) const override {
                                     ^
  /Users/buildslave/jenkins/workspace/lldb-cmake at 2/llvm-project/lldb/include/lldb/Host/common/NativeProcessProtocol.h:302:5: note: hidden overloaded virtual function 'lldb_private::NativeProcessProtocol::Manager::Launch' declared here: different number of parameters (2 vs 3)
      Launch(ProcessLaunchInfo &launch_info,
      ^
  /Users/buildslave/jenkins/workspace/lldb-cmake at 2/llvm-project/lldb/tools/lldb-server/lldb-gdbserver.cpp:84:36: error: non-virtual member function marked 'override' hides virtual member function
           MainLoop &mainloop) const override {
                                     ^
  /Users/buildslave/jenkins/workspace/lldb-cmake at 2/llvm-project/lldb/include/lldb/Host/common/NativeProcessProtocol.h:324:5: note: hidden overloaded virtual function 'lldb_private::NativeProcessProtocol::Manager::Attach' declared here: different number of parameters (2 vs 3)
      Attach(lldb::pid_t pid, NativeDelegate &native_delegate) = 0;
      ^
  /Users/buildslave/jenkins/workspace/lldb-cmake at 2/llvm-project/lldb/tools/lldb-server/lldb-gdbserver.cpp:434:24: error: variable type '(anonymous namespace)::NativeProcessManager' is an abstract class
    NativeProcessManager manager(mainloop);
                         ^
  /Users/buildslave/jenkins/workspace/lldb-cmake at 2/llvm-project/lldb/include/lldb/Host/common/NativeProcessProtocol.h:302:5: note: unimplemented pure virtual method 'Launch' in 'NativeProcessManager'
      Launch(ProcessLaunchInfo &launch_info,
      ^
  /Users/buildslave/jenkins/workspace/lldb-cmake at 2/llvm-project/lldb/include/lldb/Host/common/NativeProcessProtocol.h:324:5: note: unimplemented pure virtual method 'Attach' in 'NativeProcessManager'
      Attach(lldb::pid_t pid, NativeDelegate &native_delegate) = 0;

Could you have a look? https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/53015/console


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146977/new/

https://reviews.llvm.org/D146977