[Lldb-commits] [PATCH] D147084: [lldb] Move ObjectFileJIT to lldbExpression

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 28 14:08:39 PDT 2023


bulbazord created this revision.
bulbazord added reviewers: labath, JDevlieghere, mib, jingham, clayborg.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

In the spirit of not having lldbExpression rely on plugins, this move
makes the most sense. ObjectFileJIT is not really a "plugin" in the
sense that without it, expression evaluation doesn't work at all. This
is different than something like ObjectFileELF where lldb can still
technically debug non-ELF targets without it. For that reason, moving
ObjectFileJIT into Expression where it will be used in conjunction with
IRExecutionUnit makes the most sense.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147084

Files:
  lldb/include/lldb/Expression/IRExecutionUnit.h
  lldb/include/lldb/Expression/ObjectFileJIT.h
  lldb/include/lldb/Symbol/ObjectFile.h
  lldb/source/Expression/CMakeLists.txt
  lldb/source/Expression/IRExecutionUnit.cpp
  lldb/source/Expression/ObjectFileJIT.cpp
  lldb/source/Plugins/ObjectFile/CMakeLists.txt
  lldb/source/Plugins/ObjectFile/JIT/CMakeLists.txt
  lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.cpp
  lldb/source/Plugins/ObjectFile/JIT/ObjectFileJIT.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147084.509130.patch
Type: text/x-patch
Size: 7655 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230328/f31ff154/attachment-0001.bin>


More information about the lldb-commits mailing list