[Lldb-commits] [PATCH] D147012: [lldb] Support Universal Mach-O binaries with a fat64 header

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: lldb/source/Plugins/ObjectContainer/Universal-Mach-O/ObjectContainerUniversalMachO.cpp:205
+        const lldb::offset_t slice_file_offset =
+            fat_arch.GetOffset() + file_offset;
+        if (fat_arch.GetOffset() < file_size && file_size > slice_file_offset) {
----------------
aprantl wrote:
> Should this use AddOverflow?
> https://llvm.org/doxygen/MathExtras_8h.html
Yes, but nothing in `ObjectContainerUniversalMachO` is currently overflow aware. I'll fix up the whole file in a follow-up. 


================
Comment at: lldb/test/API/macosx/universal64/TestUniversal64.py:21
+        # Make sure the binary and the dSYM are in the image list.
+        self.expect("image list ", patterns=['fat.out', 'fat.out.dSYM'])
+
----------------
aprantl wrote:
> would it be easy to verify in the test or the makefile that the dsym indeed has a fat header?
`llvm-objdump` can dump the universal headers but that's currently not a dependency of the test suite and I didn't think it was worth adding just for a sanity check.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147012/new/

https://reviews.llvm.org/D147012